Fix NPE when using non-numeric #20277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This code is only valid when `refNumeric` exist(otherwise we didn't find such numeric PR and can skip that check) and give a free-pas to the "BEFORE" check when `ref` is nil. - Resolves go-gitea#20109
lunny
approved these changes
Jul 7, 2022
GiteaBot
added
the
lgtm/need 1
Gusted
pushed a commit
to Gusted/gitea
that referenced
this pull request
Jul 7, 2022
- Backport (go-gitea#20277 - This code is only valid when `refNumeric` exist(otherwise we didn't find such numeric PR and can skip that check) and give a free-pas to the "BEFORE" check when `ref` is nil. - Resolves go-gitea#20109
6543
approved these changes
Jul 7, 2022
GiteaBot
added
lgtm/done
lunny
pushed a commit
that referenced
this pull request
Jul 7, 2022
|
🚀 |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 8, 2022
* upstream/main: Add tooltip to repo icons in explore page (go-gitea#20241) Fix NPE when using non-numeric (go-gitea#20277)
dineshsalunke
pushed a commit
to dineshsalunke/gitea
that referenced
this pull request
Jul 9, 2022
- This code is only valid when `refNumeric` exist(otherwise we didn't find such numeric PR and can skip that check) and give a free-pas to the "BEFORE" check when `ref` is nil. - Resolves go-gitea#20109
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 10, 2022
- This code is only valid when `refNumeric` exist(otherwise we didn't find such numeric PR and can skip that check) and give a free-pas to the "BEFORE" check when `ref` is nil. - Resolves go-gitea#20109
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refNumericexist(otherwise we didn't find such numeric PR and can skip that check) and give a free-pas to the "BEFORE" check whenrefis nil.